[xmonad] Added a new simple layout

[Norbert Zeh]

... and thought I'd share. Patch is attached.

Cheers,
Norbert

[Brandon Allbery]

Post by Norbert Zeh
... and thought I'd share. Patch is attached.

A few nits:

- the comment in XMonad.Layout.Dwindle identifies it as XMonad.Layout.Spiral

- consider renaming Rotation, as anyone using your module must also import
XMonad hiding (Rotation). At the very least, you should document the
requirement if you're going to keep it, since you export it. Possible
alternate name: Chirality.

[Norbert Zeh]

Post by Brandon Allbery

Post by Norbert Zeh
... and thought I'd share. Patch is attached.

- the comment in XMonad.Layout.Dwindle identifies it as
XMonad.Layout.Spiral
- consider renaming Rotation, as anyone using your module must also import
XMonad hiding (Rotation). At the very least, you should document the
requirement if you're going to keep it, since you export it. Possible
alternate name: Chirality.

Thanks for the feedback. Ended up in my spam. I'll update that and resend
soon.

Cheers,
Norbert

[Norbert Zeh]

Post by Brandon Allbery

Post by Norbert Zeh
... and thought I'd share. Patch is attached.

- the comment in XMonad.Layout.Dwindle identifies it as
XMonad.Layout.Spiral
- consider renaming Rotation, as anyone using your module must also
import XMonad hiding (Rotation). At the very least, you should document the
requirement if you're going to keep it, since you export it. Possible
alternate name: Chirality.

Updated patch is attached. Let me know if anything else needs to be fixed.

Cheers,
Norbert

[adam vogt]

Hi Norbert,

Would you be willing to change the license to the one contrib uses?
Otherwise I suppose you should to submit the module to this (unaffiliated)
project: https://hackage.haskell.org/package/xmonad-contrib-gpl

Also, there's a XMonad.Util.Types.Direction2D that also defines L R U D
constructors. It would be better to import and use that one instead of data
Direction.

Thanks,
Adam

Post by Norbert Zeh

Post by Brandon Allbery

Post by Norbert Zeh
... and thought I'd share. Patch is attached.

- the comment in XMonad.Layout.Dwindle identifies it as
XMonad.Layout.Spiral
- consider renaming Rotation, as anyone using your module must also
import XMonad hiding (Rotation). At the very least, you should document the
requirement if you're going to keep it, since you export it. Possible
alternate name: Chirality.

Updated patch is attached. Let me know if anything else needs to be fixed.
Cheers,
Norbert
_______________________________________________
xmonad mailing list
http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad

[Norbert Zeh]

Thanks for the pointers, Adam. Updated patch is attached.

Cheers,
Norbert

Post by adam vogt
Hi Norbert,
Would you be willing to change the license to the one contrib uses?
Otherwise I suppose you should to submit the module to this (unaffiliated)
project: https://hackage.haskell.org/package/xmonad-contrib-gpl
Also, there's a XMonad.Util.Types.Direction2D that also defines L R U D
constructors. It would be better to import and use that one instead of data
Direction.
Thanks,
Adam

Post by Norbert Zeh

Post by Brandon Allbery

Post by Norbert Zeh
... and thought I'd share. Patch is attached.

- the comment in XMonad.Layout.Dwindle identifies it as
XMonad.Layout.Spiral
- consider renaming Rotation, as anyone using your module must also
import XMonad hiding (Rotation). At the very least, you should document the
requirement if you're going to keep it, since you export it. Possible
alternate name: Chirality.

Updated patch is attached. Let me know if anything else needs to be fixed.
Cheers,
Norbert
_______________________________________________
xmonad mailing list
http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad

[adam vogt]

Applied. Thanks Norbert

Post by Norbert Zeh
Thanks for the pointers, Adam. Updated patch is attached.
Cheers,
Norbert

Post by adam vogt
Hi Norbert,
Would you be willing to change the license to the one contrib uses?
Otherwise I suppose you should to submit the module to this (unaffiliated)
project: https://hackage.haskell.org/package/xmonad-contrib-gpl
Also, there's a XMonad.Util.Types.Direction2D that also defines L R U D
constructors. It would be better to import and use that one instead of data
Direction.
Thanks,
Adam

Post by Norbert Zeh

Post by Brandon Allbery

Post by Norbert Zeh
... and thought I'd share. Patch is attached.

- the comment in XMonad.Layout.Dwindle identifies it as
XMonad.Layout.Spiral
- consider renaming Rotation, as anyone using your module must also
import XMonad hiding (Rotation). At the very least, you should document the
requirement if you're going to keep it, since you export it. Possible
alternate name: Chirality.

Updated patch is attached. Let me know if anything else needs to be fixed.
Cheers,
Norbert
_______________________________________________
xmonad mailing list
http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad

_______________________________________________
xmonad mailing list
http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad