Discussion:
[xmonad] More possibilities for border width customization
Bogdan Sinitsyn
2015-12-22 19:21:59 UTC
Permalink
Sometimes it would be better to customize border width depending on window. Is
it possible to merge this functionality into core?
--
Bogdan Sinitsyn
Brent Yorgey
2015-12-29 21:10:56 UTC
Permalink
This seems to me like it would be a rather invasive breaking change
(changing the type of a field in the main xmonad config record).
Personally I do not think it would be worth it. However if someone makes a
patch, along with a reasoned justification, it will certainly be considered.

-Brent
Post by Bogdan Sinitsyn
Sometimes it would be better to customize border width depending on window. Is
it possible to merge this functionality into core?
--
Bogdan Sinitsyn
_______________________________________________
xmonad mailing list
http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad
Brandon Allbery
2015-12-29 21:19:38 UTC
Permalink
Post by Brent Yorgey
This seems to me like it would be a rather invasive breaking change
(changing the type of a field in the main xmonad config record).
Personally I do not think it would be worth it. However if someone makes a
patch, along with a reasoned justification, it will certainly be considered.
Not everything belongs in core. What I usually suggest in IRC is:

setBorder bw = ask >>= \w -> liftX (withDisplay $ \d -> io $
setWindowBorderWidth d w bw) >> idHook

and then apply it to windows in the ManageHook.
An argument could possibly be made for that function going into the core...
but probably should start out in contrib.
--
brandon s allbery kf8nh sine nomine associates
***@gmail.com ***@sinenomine.net
unix, openafs, kerberos, infrastructure, xmonad http://sinenomine.net
Bogdan Sinitsyn
2016-01-03 20:21:29 UTC
Permalink
Post by Brandon Allbery
Post by Brent Yorgey
This seems to me like it would be a rather invasive breaking change
(changing the type of a field in the main xmonad config record).
Personally I do not think it would be worth it. However if someone makes a
patch, along with a reasoned justification, it will certainly be considered.
setBorder bw = ask >>= \w -> liftX (withDisplay $ \d -> io $
setWindowBorderWidth d w bw) >> idHook
and then apply it to windows in the ManageHook.
An argument could possibly be made for that function going into the core...
but probably should start out in contrib.
This doesn't help, just like hack with layoutHook similar to X.L.NoBorders
Adding something like this to handleEventHook is not so useless, but it shows
original borders for some time, so, I think, that's not a solution.
--
Bogdan Sinitsyn
Bogdan Sinitsyn
2015-12-30 04:05:17 UTC
Permalink
Post by Brent Yorgey
This seems to me like it would be a rather invasive breaking change
(changing the type of a field in the main xmonad config record).
Personally I do not think it would be worth it. However if someone makes a
patch, along with a reasoned justification, it will certainly be considered.
-Brent
Post by Bogdan Sinitsyn
Sometimes it would be better to customize border width depending on window. Is
it possible to merge this functionality into core?
--
Bogdan Sinitsyn
_______________________________________________
xmonad mailing list
http://mail.haskell.org/cgi-bin/mailman/listinfo/xmonad
It can be done by adding new field of type `Query (Maybe Dimension)`. This
solution does not break compatibility with almost all old configurations(it
will break only those, who use `XConfig { ... }`, not `def { ... }`). PR on
GitHub is already made.
--
Bogdan Sinitsyn
Loading...